Skip to content

Conversation

@grindtildeath
Copy link
Contributor

Forward port of #1418

…k_id

The Odoo default computation for partner_bank_id on customer invoices sets
the first bank account of the company.

The override in account_payment_partner resets it to false if there is no payment mode defined.

Since for customer invoices we usually don't define a payment mode (unless when using direct debit),
this partner_bank_id field is therefore emptied.

This is problematic for instance when generating UBL invoices with the official Odoo module,
because the bank account is mandatory to create a valid Peppol document.
@grindtildeath grindtildeath changed the title 17.0 fix account payment partner default bank account [17.0][FIX] account_payment_partner: default bank account Feb 19, 2025
@grindtildeath grindtildeath force-pushed the 17.0-fix-account_payment_partner_default_bank_account branch from 5207fa7 to 044b8d3 Compare February 19, 2025 18:11
@grindtildeath
Copy link
Contributor Author

@Tisho99 One test is failing on account_vendor_bank_account_default module with latest changes in from this PR in account_payment_partner.
Looking at it, my feeling is this test was relying on the issue that is being fixed by this PR, so your help would be appreciated.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 22, 2025
@github-actions github-actions bot closed this Jul 27, 2025
@grindtildeath grindtildeath added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Aug 4, 2025
@grindtildeath grindtildeath reopened this Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants